Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect runtime-required decorators for function signatures #10091

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

charliermarsh
Copy link
Member

Summary

The original implementation of this applied the runtime-required context to definitions within the function, but not the signature itself. (We had test coverage; the snapshot was just correctly showing the wrong outcome.)

Closes #10089.

@charliermarsh charliermarsh added the bug Something isn't working label Feb 23, 2024
@charliermarsh charliermarsh enabled auto-merge (squash) February 23, 2024 03:29
@charliermarsh charliermarsh merged commit 946028e into main Feb 23, 2024
17 checks passed
@charliermarsh charliermarsh deleted the charlie/runtime-required branch February 23, 2024 03:33
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

ℹ️ ecosystem check encountered linter errors. (no lint changes; 1 project error)

rotki/rotki (error)

Failed to clone rotki/rotki: error: RPC failed; curl 92 HTTP/2 stream 0 was not closed cleanly: CANCEL (err 8)
error: 5497 bytes of body are still expected
fetch-pack: unexpected disconnect while reading sideband packet
fatal: early EOF
fatal: fetch-pack: invalid index-pack output

Linter (preview)

✅ ecosystem check detected no linter changes.

nkxxll pushed a commit to nkxxll/ruff that referenced this pull request Mar 10, 2024
…h#10091)

## Summary

The original implementation of this applied the runtime-required context
to definitions _within_ the function, but not the signature itself. (We
had test coverage; the snapshot was just correctly showing the wrong
outcome.)

Closes astral-sh#10089.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

runtime-evaluated-decorators not working for the annotations of decorated functions.
1 participant